Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add support for more backbones(mobilnet, vgg, densenet, resnext) & refactor #45

Merged
merged 12 commits into from
Feb 2, 2021

Conversation

kaushikb11
Copy link
Contributor

What does this PR do?

Add support for more backbones & refactor Image Classification

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Feb 1, 2021

Codecov Report

Merging #45 (e780ad2) into master (58d3a84) will decrease coverage by 0.48%.
The diff coverage is 61.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   80.98%   80.50%   -0.49%     
==========================================
  Files          46       47       +1     
  Lines        1383     1400      +17     
==========================================
+ Hits         1120     1127       +7     
- Misses        263      273      +10     
Flag Coverage Δ
unittests 80.50% <61.53%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/vision/classification/backbones.py 58.33% <58.33%> (ø)
flash/vision/classification/model.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d3a84...e780ad2. Read the comment docs.

Copy link
Contributor

@teddykoker teddykoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

flash/vision/classification/components/backbones.py Outdated Show resolved Hide resolved
@Borda Borda added the backbone Flash backbone label Feb 1, 2021
@kaushikb11 kaushikb11 enabled auto-merge (squash) February 2, 2021 14:33
@carmocca carmocca disabled auto-merge February 2, 2021 16:34
@carmocca carmocca enabled auto-merge (squash) February 2, 2021 16:34
@Borda Borda disabled auto-merge February 2, 2021 17:29
@Borda Borda merged commit bc00c05 into Lightning-Universe:master Feb 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backbone Flash backbone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants