-
Notifications
You must be signed in to change notification settings - Fork 212
Docs for backbones #735
Docs for backbones #735
Conversation
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #735 +/- ##
==========================================
- Coverage 89.06% 85.57% -3.50%
==========================================
Files 198 198
Lines 10681 10681
==========================================
- Hits 9513 9140 -373
- Misses 1168 1541 +373
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hey @bamblebam thanks for your work on this 😃 Since our available backbones change quite a lot and depend on which dependencies you have installed, I think it might be better here to just document how to use the |
Yeah sounds good I will get that done. |
…g-flash into backbone-docs
for more information, see https://pre-commit.ci
I added docs for the available backbones part but when I run |
Hi @bamblebam that would be expected for those tasks since they don't have configurable heads. You should get something if you use Thanks 😃 |
@ethanwharris I checked for available heads but |
@ethanwharris did you take a look ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!!! I left a few comments, you will also need to add it at the bottom of index.rst
I think. Thanks 😃
I updated the index.rst file. I am also marking this as ready for review if there is anything else you want me to do let me know. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! LGTM 😃
What does this PR do?
Fixes #718
Adds a central page which has a table table containing available backbones for all the tasks.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃