Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Docs for backbones #735

Merged
merged 13 commits into from
Sep 11, 2021
Merged

Conversation

bamblebam
Copy link
Contributor

What does this PR do?

Fixes #718
Adds a central page which has a table table containing available backbones for all the tasks.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@bamblebam
Copy link
Contributor Author

How the page looks.
image

@codecov
Copy link

codecov bot commented Sep 6, 2021

Codecov Report

Merging #735 (f4b8559) into master (23328bd) will decrease coverage by 3.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
- Coverage   89.06%   85.57%   -3.50%     
==========================================
  Files         198      198              
  Lines       10681    10681              
==========================================
- Hits         9513     9140     -373     
- Misses       1168     1541     +373     
Flag Coverage Δ
unittests 85.57% <ø> (-3.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/model.py 29.16% <0.00%> (-61.81%) ⬇️
flash/text/question_answering/data.py 28.29% <0.00%> (-57.88%) ⬇️
flash/text/classification/cli.py 57.14% <0.00%> (-42.86%) ⬇️
flash/text/question_answering/cli.py 58.33% <0.00%> (-41.67%) ⬇️
flash/text/seq2seq/core/utils.py 70.00% <0.00%> (-30.00%) ⬇️
flash/text/classification/data.py 62.92% <0.00%> (-28.09%) ⬇️
flash/text/seq2seq/core/metrics.py 74.07% <0.00%> (-25.00%) ⬇️
flash/text/seq2seq/core/data.py 65.85% <0.00%> (-24.40%) ⬇️
flash/text/classification/model.py 70.68% <0.00%> (-22.42%) ⬇️
flash/text/question_answering/finetuning.py 5.49% <0.00%> (-14.29%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23328bd...f4b8559. Read the comment docs.

@ethanwharris
Copy link
Collaborator

Hey @bamblebam thanks for your work on this 😃 Since our available backbones change quite a lot and depend on which dependencies you have installed, I think it might be better here to just document how to use the available_backbones and available_heads methods. E.g. you could have an example of available_backbones for the image classifier then available_heads, available_backbones(head) for the ObjectDetector. What do you think?

@bamblebam
Copy link
Contributor Author

Yeah sounds good I will get that done.

@bamblebam
Copy link
Contributor Author

bamblebam commented Sep 7, 2021

I added docs for the available backbones part but when I run print(ObjectDetector.available_heads()) it returns an empty list. Is this intended behaviour?
Also TextClassifier.available_backbones() returns an empty list as well. Is this also intended?

@ethanwharris
Copy link
Collaborator

Hi @bamblebam that would be expected for those tasks since they don't have configurable heads. You should get something if you use available_heads with either SemanticSegmentation or ObjectDetector.

Thanks 😃

@akihironitta akihironitta added the documentation Improvements or additions to documentation label Sep 8, 2021
@bamblebam
Copy link
Contributor Author

@ethanwharris I checked for available heads but ObjectDetector.available_heads() still returns an empty list. Though SemanticSegmentation.available_heads() returns a list.
I also did the docs so take a look at that and let me know if something needs to be added.
image

@bamblebam
Copy link
Contributor Author

@ethanwharris did you take a look ?

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!! I left a few comments, you will also need to add it at the bottom of index.rst I think. Thanks 😃

docs/source/general/backbones.rst Outdated Show resolved Hide resolved
docs/source/general/backbones.rst Outdated Show resolved Hide resolved
docs/source/general/backbones.rst Outdated Show resolved Hide resolved
docs/source/general/backbones.rst Outdated Show resolved Hide resolved
@bamblebam
Copy link
Contributor Author

I updated the index.rst file. I am also marking this as ready for review if there is anything else you want me to do let me know.

@bamblebam bamblebam marked this pull request as ready for review September 10, 2021 11:49
Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! LGTM 😃

@ethanwharris ethanwharris enabled auto-merge (squash) September 11, 2021 09:28
@ethanwharris ethanwharris merged commit d9ae5d0 into Lightning-Universe:master Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List of models that can be used as a backbone
4 participants