Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add thumbnails to card items #787

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Add thumbnails to card items #787

merged 2 commits into from
Sep 22, 2021

Conversation

SeanNaren
Copy link
Contributor

@SeanNaren SeanNaren commented Sep 22, 2021

What does this PR do?

Adds thumbnails to the card items. @ethanwharris to help me out get them onto S3 :)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Sep 22, 2021

Codecov Report

Merging #787 (262f310) into master (d190c76) will decrease coverage by 3.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
- Coverage   89.62%   85.76%   -3.87%     
==========================================
  Files         213      213              
  Lines       11317    11317              
==========================================
- Hits        10143     9706     -437     
- Misses       1174     1611     +437     
Flag Coverage Δ
unittests 85.76% <ø> (-3.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/text/question_answering/model.py 29.16% <0.00%> (-61.81%) ⬇️
flash/text/question_answering/data.py 28.29% <0.00%> (-58.53%) ⬇️
flash/text/classification/cli.py 53.84% <0.00%> (-46.16%) ⬇️
flash/text/question_answering/cli.py 60.00% <0.00%> (-40.00%) ⬇️
flash/text/seq2seq/core/utils.py 70.00% <0.00%> (-30.00%) ⬇️
flash/text/classification/data.py 62.92% <0.00%> (-28.09%) ⬇️
flash/text/seq2seq/core/metrics.py 74.07% <0.00%> (-25.00%) ⬇️
flash/text/seq2seq/core/data.py 65.85% <0.00%> (-24.40%) ⬇️
flash/text/classification/model.py 69.09% <0.00%> (-23.64%) ⬇️
flash/text/question_answering/finetuning.py 5.49% <0.00%> (-14.29%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d190c76...262f310. Read the comment docs.

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Copy link
Collaborator

@ethanwharris ethanwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@ethanwharris ethanwharris merged commit 742fe2e into master Sep 22, 2021
@ethanwharris ethanwharris deleted the thumbnails branch September 22, 2021 11:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants