Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add PreprocessTransform #852

Merged
merged 13 commits into from
Oct 12, 2021
Merged

Add PreprocessTransform #852

merged 13 commits into from
Oct 12, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 11, 2021

What does this PR do?

This PR is part of an internal refactor of the DataPipeline.

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #852 (64e376d) into master (0449611) will increase coverage by 0.03%.
The diff coverage is 92.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #852      +/-   ##
==========================================
+ Coverage   89.04%   89.08%   +0.03%     
==========================================
  Files         225      226       +1     
  Lines       12186    12348     +162     
==========================================
+ Hits        10851    11000     +149     
- Misses       1335     1348      +13     
Flag Coverage Δ
unittests 89.08% <92.02%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/process.py 87.70% <ø> (-0.06%) ⬇️
flash/core/data/preprocess_transform.py 92.02% <92.02%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0449611...64e376d. Read the comment docs.

@tchaton tchaton changed the title Add PreTransform Add PreprocessTransform Oct 12, 2021
@tchaton tchaton merged commit 8f5a64a into master Oct 12, 2021
@tchaton tchaton deleted the flash_transform branch October 12, 2021 08:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants