Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add FlashDataset update #853

Merged
merged 4 commits into from
Oct 11, 2021
Merged

Add FlashDataset update #853

merged 4 commits into from
Oct 11, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 11, 2021

What does this PR do?

Fixes #851

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

Merging #853 (54182d2) into master (5d0b329) will decrease coverage by 4.11%.
The diff coverage is 100.00%.

❗ Current head 54182d2 differs from pull request most recent head d0b9086. Consider uploading reports for the commit d0b9086 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
- Coverage   89.02%   84.91%   -4.12%     
==========================================
  Files         225      225              
  Lines       12186    12187       +1     
==========================================
- Hits        10849    10349     -500     
- Misses       1337     1838     +501     
Flag Coverage Δ
unittests 84.91% <100.00%> (-4.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/data/datasets.py 95.71% <100.00%> (+2.96%) ⬆️
flash/text/question_answering/model.py 28.76% <0.00%> (-62.33%) ⬇️
flash/text/question_answering/data.py 27.93% <0.00%> (-59.05%) ⬇️
flash/text/classification/cli.py 53.84% <0.00%> (-46.16%) ⬇️
flash/text/question_answering/cli.py 60.00% <0.00%> (-40.00%) ⬇️
flash/text/classification/data.py 55.03% <0.00%> (-37.99%) ⬇️
flash/text/seq2seq/core/utils.py 70.00% <0.00%> (-30.00%) ⬇️
flash/text/seq2seq/core/metrics.py 74.07% <0.00%> (-25.00%) ⬇️
flash/text/seq2seq/core/data.py 65.85% <0.00%> (-24.40%) ⬇️
flash/text/classification/model.py 69.09% <0.00%> (-23.64%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d0b329...d0b9086. Read the comment docs.

@tchaton tchaton merged commit 5dae199 into master Oct 11, 2021
@tchaton tchaton deleted the flash_dataset_info branch October 11, 2021 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants