Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Freeze structlog version #860

Merged
merged 1 commit into from
Oct 12, 2021
Merged

Freeze structlog version #860

merged 1 commit into from
Oct 12, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 12, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@tchaton tchaton self-assigned this Oct 12, 2021
@tchaton tchaton added the bug / fix Something isn't working label Oct 12, 2021
@tchaton tchaton added this to the v0.6 milestone Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #860 (e2f1709) into master (e8a64a0) will decrease coverage by 14.85%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #860       +/-   ##
===========================================
- Coverage   78.16%   63.31%   -14.86%     
===========================================
  Files         226      226               
  Lines       12355    12355               
===========================================
- Hits         9657     7822     -1835     
- Misses       2698     4533     +1835     
Flag Coverage Δ
unittests 63.31% <ø> (-14.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/serve/dag/visualize.py 19.04% <0.00%> (-76.20%) ⬇️
flash/core/integrations/labelstudio/visualizer.py 22.00% <0.00%> (-74.00%) ⬇️
flash/core/serve/component.py 21.69% <0.00%> (-72.65%) ⬇️
...ash/pointcloud/segmentation/open3d_ml/backbones.py 20.83% <0.00%> (-70.84%) ⬇️
...ash/pointcloud/detection/open3d_ml/data_sources.py 23.93% <0.00%> (-66.67%) ⬇️
...tcloud/segmentation/open3d_ml/sequences_dataset.py 20.18% <0.00%> (-63.31%) ⬇️
flash/core/serve/interfaces/http.py 35.44% <0.00%> (-62.03%) ⬇️
flash/core/serve/flash_components.py 29.62% <0.00%> (-61.12%) ⬇️
flash/image/segmentation/backbones.py 41.17% <0.00%> (-58.83%) ⬇️
flash/core/serve/composition.py 42.25% <0.00%> (-57.75%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8a64a0...e2f1709. Read the comment docs.

@tchaton tchaton merged commit 6a130ca into master Oct 12, 2021
@tchaton tchaton deleted the fix_for_structlog branch October 12, 2021 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug / fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant