Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add Serving to RunningStage #872

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Add Serving to RunningStage #872

merged 1 commit into from
Oct 14, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Oct 14, 2021

What does this PR do?

Fixes # (issue)

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 14, 2021

Codecov Report

Merging #872 (d1e0237) into master (b22e786) will decrease coverage by 0.04%.
The diff coverage is 85.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #872      +/-   ##
==========================================
- Coverage   85.05%   85.00%   -0.05%     
==========================================
  Files         227      228       +1     
  Lines       12600    12632      +32     
==========================================
+ Hits        10717    10738      +21     
- Misses       1883     1894      +11     
Flag Coverage Δ
unittests 85.00% <85.24%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/core/utilities/stages.py 73.91% <73.91%> (ø)
flash/core/data/properties.py 94.11% <81.25%> (-5.89%) ⬇️
flash/core/data/auto_dataset.py 100.00% <100.00%> (ø)
flash/core/data/base_viz.py 100.00% <100.00%> (ø)
flash/core/data/batch.py 95.93% <100.00%> (ø)
flash/core/data/callback.py 100.00% <100.00%> (ø)
flash/core/data/data_module.py 94.18% <100.00%> (ø)
flash/core/data/data_pipeline.py 95.23% <100.00%> (-0.02%) ⬇️
flash/core/data/data_source.py 94.78% <100.00%> (ø)
flash/core/data/datasets.py 94.17% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b22e786...d1e0237. Read the comment docs.

@tchaton tchaton merged commit 4f608b0 into master Oct 14, 2021
@tchaton tchaton deleted the add_serving branch October 14, 2021 20:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant