Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

VISSL datapipeline fix #880

Merged
merged 12 commits into from
Oct 21, 2021
Merged

VISSL datapipeline fix #880

merged 12 commits into from
Oct 21, 2021

Conversation

ananyahjha93
Copy link
Contributor

@ananyahjha93 ananyahjha93 commented Oct 20, 2021

What does this PR do?

Fixes datapipeline to work with VISSL's list transforms + adds process-state for PerSampleTransformOnDevice, PerBatchTransform, PerBatchTransformOnDevice. Adds option to set these to None and override the defaults provided.

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests? [not needed for typos/docs]
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #880 (96192ba) into master (b41722a) will increase coverage by 0.01%.
The diff coverage is 91.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #880      +/-   ##
==========================================
+ Coverage   85.25%   85.26%   +0.01%     
==========================================
  Files         230      230              
  Lines       12666    12706      +40     
==========================================
+ Hits        10798    10834      +36     
- Misses       1868     1872       +4     
Flag Coverage Δ
unittests 85.26% <91.83%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
flash/image/embedding/model.py 89.83% <83.33%> (-0.92%) ⬇️
flash/core/data/process.py 87.77% <91.17%> (+0.07%) ⬆️
flash/core/data/states.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b41722a...96192ba. Read the comment docs.

@ananyahjha93 ananyahjha93 enabled auto-merge (squash) October 20, 2021 21:16
@ananyahjha93 ananyahjha93 requested a review from tchaton October 21, 2021 19:20
@tchaton tchaton disabled auto-merge October 21, 2021 19:25
@tchaton tchaton merged commit 1dcdbbe into master Oct 21, 2021
@tchaton tchaton deleted the fix/vissl_datapipeline branch October 21, 2021 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants