This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananyahjha93
requested review from
Borda,
carmocca,
ethanwharris,
justusschock,
kaushikb11 and
tchaton
as code owners
October 20, 2021 15:45
ananyahjha93
commented
Oct 20, 2021
for more information, see https://pre-commit.ci
Codecov Report
@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 85.25% 85.26% +0.01%
==========================================
Files 230 230
Lines 12666 12706 +40
==========================================
+ Hits 10798 10834 +36
- Misses 1868 1872 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…ghtning/lightning-flash into fix/vissl_datapipeline
for more information, see https://pre-commit.ci
…ghtning/lightning-flash into fix/vissl_datapipeline
tchaton
reviewed
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes datapipeline to work with VISSL's list transforms + adds process-state for PerSampleTransformOnDevice, PerBatchTransform, PerBatchTransformOnDevice. Adds option to set these to None and override the defaults provided.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃