Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax sentencepiece dependency. #8

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

kvochko
Copy link
Member

@kvochko kvochko commented Nov 23, 2024

This commit relaxes sentencepiece dependency. On windows there are no pre-built wheels for sentencepiece satisfying the current version constraints for recent versions of python, and building from a source distribution is unreliable.

This commit relaxes sentencepiece dependency. On windows there are no
pre-built wheels for sentencepiece satisfying the current version
constraints for recent versions of python, and building from a source
distribution is unreliable.
@ofirbb ofirbb self-assigned this Nov 23, 2024
@ofirbb ofirbb requested a review from SapirW November 23, 2024 11:20
@ofirbb
Copy link
Member

ofirbb commented Nov 23, 2024

Inference script runs as expected with sentencepiece==0.2.0.

@ofirbb ofirbb merged commit 23f1048 into Lightricks:main Nov 23, 2024
@kvochko kvochko deleted the sentencepiece branch November 23, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants