Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction / UTXO Labeling #59

Closed
KayBeSee opened this issue Apr 29, 2021 · 3 comments
Closed

Transaction / UTXO Labeling #59

KayBeSee opened this issue Apr 29, 2021 · 3 comments
Labels
tabconf Issues ideal for TABConf's Builder Day

Comments

@KayBeSee
Copy link
Collaborator

Be able to add labels to UTXOs / Transactions.

Related to #58 and #38 since labels will be saved to a file.

@KayBeSee KayBeSee added the tabconf Issues ideal for TABConf's Builder Day label Oct 12, 2022
@KayBeSee
Copy link
Collaborator Author

Address labeling added via 64ca20e

@KayBeSee
Copy link
Collaborator Author

Thinking through this ticket a bit more and realizing that tagging transactions / utxos specifically seems unnecessary. Everything really revolves around addresses -> transactions -> UTXOs.

I'm starting to think that tagging individual UTXOs is a bad idea and should rely on pulling tags from the address and transaction the UTXO was sent to / sent in.

If we are going to tag a UTXO "KYC" or "Swan" or "CashApp" or "Non KYC", then those same tags would apply to the transaction or address

i.e.

I send bitcoin to CashApp, tag the transaction as "CashApp" and "KYC" and then that label should be applied to my change address too.

If I receive bitcoin from Swan, I should have that address already tagged as "Swan" and "KYC" but if I don't, I can add that in the transaction tag field.

In fact, even transactions shouldn't really have tags associated with them directly since transactions are just made up of money going to/from addresses.

So the retrieval logic should go through all inputs/outputs and look up tags based on address and then display them in transaction details.

KayBeSee added a commit that referenced this issue Oct 20, 2022
allows a description to be added to a transaction

see #59
KayBeSee added a commit that referenced this issue Oct 21, 2022
allows a description to be added to a transaction

see #59
KayBeSee added a commit that referenced this issue Oct 21, 2022
KayBeSee added a commit that referenced this issue Oct 21, 2022
KayBeSee added a commit that referenced this issue Oct 21, 2022
KayBeSee added a commit that referenced this issue Oct 21, 2022
KayBeSee added a commit that referenced this issue Oct 21, 2022
@KayBeSee
Copy link
Collaborator Author

This is nearly complete.

I added:

  • UTXO tags (via address tags)
  • Address tags
  • Transaction descriptions
  • Transaction tags (via address tags)

You can also search UTXOs and Addresses in the Settings page.

I think the last item to include is search on the transactions view and then this can be closed out.

KayBeSee added a commit that referenced this issue Oct 23, 2022
KayBeSee added a commit that referenced this issue Oct 23, 2022
KayBeSee added a commit that referenced this issue Oct 26, 2022
KayBeSee added a commit that referenced this issue Oct 26, 2022
…tion to add/delete multiple correctly (#105)

* feat: reference address/change address context in utxo, allow TagsSection to add/delete multiple correctly

* feat: add transaction search

see #59
KayBeSee added a commit that referenced this issue Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tabconf Issues ideal for TABConf's Builder Day
Projects
None yet
Development

No branches or pull requests

1 participant