Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace FastRelaxedClockLogNormal to ORC #151

Closed
walterxie opened this issue Sep 4, 2024 · 4 comments
Closed

replace FastRelaxedClockLogNormal to ORC #151

walterxie opened this issue Sep 4, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@walterxie
Copy link
Collaborator

walterxie commented Sep 4, 2024

For relaxed clock, replace FastRelaxedClockLogNormal to ORC https://github.com/jordandouglas/ORC/

https://doi.org/10.1371/journal.pcbi.1008322

@walterxie walterxie added the enhancement New feature or request label Sep 4, 2024
walterxie added a commit that referenced this issue Sep 4, 2024
@walterxie
Copy link
Collaborator Author

walterxie commented Sep 13, 2024

Tips:

  1. LogNormal distr in prior can be reused in branchRateModel.
  2. mean in real space has to be 1, otherwise there is scaling issue in MCMC. So, the lphy code must have branchRate LogNormal(mean in real=1, ...);.
<prior id="ORCRatePriorDistribution.c:CRC01" name="distribution" x="@ORCRates.c:CRC01">
                    <LogNormal id="LogNormalDistributionModel.0" S="@ORCsigma.c:CRC01" meanInRealSpace="true" name="distr">
                        <parameter id="RealParameter.47" spec="parameter.RealParameter" estimate="false" name="M">1.0</parameter>
                    </LogNormal>
                </prior>

<branchRateModel id="OptimisedRelaxedClock.c:CRC01" spec="beast.base.evolution.branchratemodel.UCRelaxedClockModel" clock.rate="@ORCucldMean.c:CRC01" rates="@ORCRates.c:CRC01" tree="@Tree.t:CRC01">
                        <LogNormal id="ORCLogNormalDistributionModel.c:CRC01" S="@ORCsigma.c:CRC01" meanInRealSpace="true" name="distr">
                            <parameter id="RealParameter.46" spec="parameter.RealParameter" estimate="false" name="M">1.0</parameter>
                        </LogNormal>
                    </branchRateModel>

@walterxie
Copy link
Collaborator Author

The incomplete dev is in branch b2.7ops https://github.com/LinguaPhylo/LPhyBeast/tree/b2.7ops

walterxie added a commit to LinguaPhylo/linguaPhylo that referenced this issue Sep 13, 2024
@walterxie
Copy link
Collaborator Author

use UCLN LinguaPhylo/linguaPhylo#488

walterxie added a commit that referenced this issue Oct 14, 2024
@walterxie
Copy link
Collaborator Author

walterxie commented Oct 15, 2024

TODO: how to disable <operator id="YuleModelNarrow" spec="Exchange" tree="@Tree" weight="..."/>, which is duplicated between added extra operator and default tree operators?

// 4. NER
// ORCNER_Exchange
Exchange exchange = new Exchange();
exchange.initByName("tree", tree, "weight", 1.0);
exchange.setID("ORCNER_Exchange.NER." + tree.getID());
//TODO disable <operator id="YuleModelNarrow" spec="Exchange" tree="@Tree" weight="0.0"/>

walterxie added a commit that referenced this issue Oct 15, 2024
walterxie added a commit that referenced this issue Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant