Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator for supporting negative values #156

Closed
walterxie opened this issue Sep 25, 2024 · 6 comments
Closed

Operator for supporting negative values #156

walterxie opened this issue Sep 25, 2024 · 6 comments
Labels
bug Something isn't working critical change the bug fix or new feature will significant change the code

Comments

@walterxie
Copy link
Collaborator

From Alexei:

While looking at the LPhyBEAST code with Sebastian Hoehna we noticed that there is a bug for RealParameters in the DefaultOperatorSchedule. If the parameter comes from a Normal or Laplace distribution (or any distribution with support in negative values) the it should have a RandomWalkOperator instead of a ScaleOperator.

@walterxie walterxie added bug Something isn't working critical change the bug fix or new feature will significant change the code labels Sep 25, 2024
@walterxie
Copy link
Collaborator Author

@walterxie
Copy link
Collaborator Author

walterxie commented Sep 26, 2024

I think it is solved :

Θ ~ Normal(mean=3.0, sd=1.0); now produces:

<distribution id="Theta.prior" spec="distribution.Prior" x="@Theta">
     <distr id="Normal" spec="distribution.Normal">
            <parameter id="RealParameter1" spec="parameter.RealParameter" name="mean">3.0</parameter>
            <parameter id="RealParameter2" spec="parameter.RealParameter" name="sigma">1.0</parameter>
     </distr>
</distribution>

...

<operator id="Theta.randomWalk" spec="operator.kernel.BactrianRandomWalkOperator" parameter="@Theta" scaleFactor="0.75" weight="1.0"/>

@alexeid
Copy link
Collaborator

alexeid commented Sep 26, 2024

Should there be a scale factor for a random walk? I thought it should be window size?

@walterxie
Copy link
Collaborator Author

BactrianRandomWalkOperator uses scale factor https://github.com/CompEvol/beast2/blob/master/src/beast/base/inference/operator/kernel/BactrianRandomWalkOperator.java . I have emailed Remco, and will let you know after he replies.

@walterxie
Copy link
Collaborator Author

CompEvol/beast2#1169

@walterxie
Copy link
Collaborator Author

close this for new release. create #165 to remind updating after beast2 new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working critical change the bug fix or new feature will significant change the code
Projects
None yet
Development

No branches or pull requests

2 participants