-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Operator for supporting negative values #156
Comments
I think it is solved :
<distribution id="Theta.prior" spec="distribution.Prior" x="@Theta">
<distr id="Normal" spec="distribution.Normal">
<parameter id="RealParameter1" spec="parameter.RealParameter" name="mean">3.0</parameter>
<parameter id="RealParameter2" spec="parameter.RealParameter" name="sigma">1.0</parameter>
</distr>
</distribution>
...
<operator id="Theta.randomWalk" spec="operator.kernel.BactrianRandomWalkOperator" parameter="@Theta" scaleFactor="0.75" weight="1.0"/>
|
Should there be a scale factor for a random walk? I thought it should be window size? |
BactrianRandomWalkOperator uses scale factor https://github.com/CompEvol/beast2/blob/master/src/beast/base/inference/operator/kernel/BactrianRandomWalkOperator.java . I have emailed Remco, and will let you know after he replies. |
close this for new release. create #165 to remind updating after beast2 new release. |
From Alexei:
While looking at the LPhyBEAST code with Sebastian Hoehna we noticed that there is a bug for RealParameters in the DefaultOperatorSchedule. If the parameter comes from a Normal or Laplace distribution (or any distribution with support in negative values) the it should have a RandomWalkOperator instead of a ScaleOperator.
The text was updated successfully, but these errors were encountered: