Skip to content

Commit

Permalink
tools: enable no-cond-assign-ESLint rule
Browse files Browse the repository at this point in the history
no-cond-assign is one of the few ESLint recommended rules that we have
turned off. This change enables the rule.

PR-URL: nodejs#41614
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
Trott authored and Linkgoron committed Jan 31, 2022
1 parent 1e601ac commit 3210cba
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,6 @@ module.exports = {
'valid-typeof': ['error', { requireStringLiterals: true }],

// ESLint recommended rules that we disable
'no-cond-assign': 'off',
'no-empty': 'off',
'no-inner-declarations': 'off',
'no-prototype-builtins': 'off',
Expand Down

0 comments on commit 3210cba

Please sign in to comment.