Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust 1.78 introduced unsafe precondition checks when debug assertions are enabled (rust-lang/rust#120594), and they are causing this crate to panic in debug builds:
This PR fixes two categories of errors:
get_unchecked_mut()
will panic if you try to get a pointer past the last element of the slice. The fix here is to ensure thatmove_tail_unchecked()
always gets called first with a non-zero value.slice::from_raw_parts()
will panic if the slice is unaligned. I'm not sure whyas_slices()
ever needed to use this, and I don't see any issue with just using an empty slice literal (&[]
).With this I'm able to pass the full test suite on both Rust 1.78 and nightly.