feat: add ed25519/secp256k1 precompiles #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinheavey
reviewed
Oct 18, 2024
kevinheavey
reviewed
Oct 18, 2024
|
Have implemented both suggestions |
kevinheavey
reviewed
Oct 20, 2024
svm/src/precompiles.rs
Outdated
| account.set_lamports(1); | ||
| account.set_executable(true); | ||
|
|
||
| svm.set_account(ed25519_program::ID, account.clone().into()) |
There was a problem hiding this comment.
I looked at bank.rs and it checks each precompile against the feature_set before adding it:
for precompile in get_precompiles() {
let should_add_precompile = precompile
.feature
.as_ref()
.map(|feature_id| self.feature_set.is_active(feature_id))
.unwrap_or(false);
if should_add_precompile {
self.add_precompile(&precompile.program_id);
}
}
Can we do the same please? We already have a feature_set field on LiteSVM
There was a problem hiding this comment.
Implemented in 4ea8b29
There was a problem hiding this comment.
Strange, seems the bank code has a logic error/poor wording. These precompiles have feature_id: None which means always enabled. But the code doesn't enable them. My guess is they're loaded elsewhere so it just works... cool.
Aursen
approved these changes
Oct 25, 2024
|
Hi can you add an entry in the Changelog? |
|
done |
|
Waiting for a last check of @kevinheavey and after sounds good to me |
kevinheavey
approved these changes
Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch ed25519/secp256k1 fail with: