Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle base fees and include failed transactions in transaction history #50

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

kevinheavey
Copy link
Collaborator

  • Subtracts the base fee from the payer account for both successful and failed transactions. "Failed" transaction here is supposed to mean a transaction that would get included in a block with an error code, as opposed to one that just gets dropped.
  • Added some error logs to make it easier to tell where errors occurred. These are noops unless the user activates them with env_logger or whatever
  • Changed the transaction history to include failed transactions (sorry for putting this all in one PR)

@kevinheavey kevinheavey requested a review from Aursen April 2, 2024 02:02
@kevinheavey kevinheavey merged commit 8efeab0 into master Apr 2, 2024
2 checks passed
@Aursen Aursen deleted the fee-collection branch April 2, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants