Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move bpf_loader helpers to tests #69

Merged
merged 3 commits into from
Apr 22, 2024
Merged

move bpf_loader helpers to tests #69

merged 3 commits into from
Apr 22, 2024

Conversation

kevinheavey
Copy link
Collaborator

@Aursen I think set_upgrade_authority and deploy_upgradeable_program should be kept out of the core API. We can make a helper crate for them later but for now I've just moved the functions to the tests

@kevinheavey kevinheavey requested a review from Aursen April 22, 2024 15:36
Aursen
Aursen approved these changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@Aursen Aursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will simplify the API. Sounds good to me

@kevinheavey kevinheavey merged commit 30d67c5 into master Apr 22, 2024
2 checks passed
@kevinheavey kevinheavey deleted the bpf-helpers-examples branch April 22, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aursen Aursen Aursen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @Aursen