Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make log_bytes_limit configurable #96

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Make log_bytes_limit configurable #96

merged 2 commits into from
Oct 11, 2024

Conversation

kevinheavey
Copy link
Collaborator

This supercedes the two previous PRs that did this.

Closes #72
Closes #71

Aursen
Aursen approved these changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@Aursen Aursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a huge fan of usize, but it can handle more cases. The PR seems fine to me

@Aursen Aursen changed the title make log_bytes_limit configurable Make log_bytes_limit configurable Oct 11, 2024
@kevinheavey kevinheavey merged commit 8f11db5 into master Oct 11, 2024
2 checks passed
@Aursen Aursen deleted the log-collector-bytes-2 branch October 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aursen Aursen Aursen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinheavey @Aursen