Skip to content

Commit

Permalink
fix: drop table with watermark panic (risingwavelabs#8990)
Browse files Browse the repository at this point in the history
  • Loading branch information
yuhao-su authored Apr 4, 2023
1 parent b9ff193 commit 506986f
Showing 2 changed files with 6 additions and 1 deletion.
6 changes: 6 additions & 0 deletions e2e_test/ddl/table/watermark.slt.part
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
# Create a table with watermark.
statement ok
create table t1 (v1 int, v2 timestamp with time zone, watermark for v2 as v2 - INTERVAL '10 MINUTES') append only;

statement ok
drop table t1;
1 change: 0 additions & 1 deletion src/meta/src/rpc/ddl_controller.rs
Original file line number Diff line number Diff line change
@@ -532,7 +532,6 @@ where
.await;
Ok((version, delete_jobs))
} else {
assert!(internal_table_ids.is_empty());
self.catalog_manager
.drop_table(table_id, internal_table_ids)
.await

0 comments on commit 506986f

Please sign in to comment.