Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

feat: add Plex authentification #229

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

zdimension
Copy link
Collaborator

Description

Adds a setting that allows requiring Plex authentication to access the web UI. This is useful especially if the user wants to expose the web UI to the outside world.

Screenshot

image
image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: Patch coverage is 66.12903% with 21 lines in your changes missing coverage. Please review.

Project coverage is 66.43%. Comparing base (6ccf241) to head (ab60056).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
- Coverage   71.84%   66.43%   -5.42%     
==========================================
  Files          12       12              
  Lines        1087     1147      +60     
==========================================
- Hits          781      762      -19     
- Misses        306      385      +79     
Flag Coverage Δ
Linux 66.34% <64.51%> (-5.14%) ⬇️
Windows 65.91% <56.45%> (-5.58%) ⬇️
macOS 66.34% <64.51%> (-5.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
Contents/Code/default_prefs.py 100.00% <ø> (ø)
Contents/Code/plex_api_helper.py 50.58% <100.00%> (-2.75%) ⬇️
Contents/Code/webapp.py 59.04% <59.61%> (-9.08%) ⬇️

... and 3 files with indirect coverage changes

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any thoughts on unit/functional tests?

Contents/Code/default_prefs.py Show resolved Hide resolved
Contents/Code/webapp.py Show resolved Hide resolved
Contents/Code/webapp.py Show resolved Hide resolved
Contents/DefaultPrefs.json Outdated Show resolved Hide resolved
Contents/Resources/web/templates/navbar.html Show resolved Hide resolved
Contents/Resources/web/js/plexauth.js Outdated Show resolved Hide resolved
Contents/Resources/web/js/plexauth.js Outdated Show resolved Hide resolved
Contents/Resources/web/js/plexauth.js Outdated Show resolved Hide resolved
Contents/Resources/web/js/plexauth.js Outdated Show resolved Hide resolved
Contents/Resources/web/templates/login.html Outdated Show resolved Hide resolved
@LizardByte-bot
Copy link
Member

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

@zdimension
Copy link
Collaborator Author

It looks like this PR has been idle for 90 days. If it's still something you're working on or would like to pursue, please leave a comment or update your branch. Otherwise, we'll be closing this PR in 10 days to reduce our backlog. Thanks!

Not really sure what more I can do here, we were discussing testing at one point but I don't really know how I would go about testing this

@ReenigneArcher
Copy link
Member

Would you be okay with me pushing some commits to handle the testing?

@zdimension
Copy link
Collaborator Author

Would you be okay with me pushing some commits to handle the testing?

Absolutely, thanks!

@ReenigneArcher ReenigneArcher force-pushed the plex-login branch 2 times, most recently from a2dbcf8 to 05fe7a0 Compare July 21, 2024 22:10
@ReenigneArcher ReenigneArcher force-pushed the plex-login branch 9 times, most recently from ed0d4ff to e3da810 Compare July 24, 2024 02:40
@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher self-assigned this Jul 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants