Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): ensure widgetbot doesn't add padding below footers #44

Conversation

ReenigneArcher
Copy link
Member

Description

Widgetbot can create a small padding below footers, which is often a different color than the footer color. Positioning the widgetbot-crate element seems to help.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.26%. Comparing base (d87beb8) to head (95cb3e3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #44      +/-   ##
==========================================
+ Coverage   71.55%   72.26%   +0.71%     
==========================================
  Files           9        9              
  Lines         116      119       +3     
  Branches       25       25              
==========================================
+ Hits           83       86       +3     
  Misses         33       33              
Files with missing lines Coverage Δ
src/js/discord.js 88.88% <100.00%> (+2.22%) ⬆️

@ReenigneArcher ReenigneArcher merged commit bf79545 into master Sep 21, 2024
11 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/style/ensure-widgetbot-doesn't-add-padding-below-footers branch September 21, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant