Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added GEO section and rule #137

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Added GEO section and rule #137

merged 7 commits into from
Jul 20, 2023

Conversation

mrtn78
Copy link
Member

@mrtn78 mrtn78 commented Jun 13, 2023

No description provided.

@mrtn78 mrtn78 requested a review from strijm June 13, 2023 10:54
strijm
strijm requested changes Jun 13, 2023
View reviewed changes
DesignRules.md Show resolved Hide resolved
DesignRules.md Outdated Show resolved Hide resolved
DesignRules.md Outdated Show resolved Hide resolved
@mrtn78 mrtn78 added Status: Ter goedkeuring Het voorstel is uitgewerkt en wordt ter goedkeuring aangeboden. Type: Wijziging Inhoudelijke wijziging op een standaard Overleg: TO API Te agenderen voor het Technisch Overleg ADR - API Design Rules Scope: Groot Grote wijziging met grote impact labels Jul 6, 2023
@mrtn78 mrtn78 added this to the release 2.0.0 milestone Jul 10, 2023
@mrtn78 mrtn78 requested a review from lvdbrink July 12, 2023 14:22
lvdbrink
lvdbrink approved these changes Jul 13, 2023
View reviewed changes
Copy link
Collaborator

@lvdbrink lvdbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one typo (becomming > becoming) but other than that it looks good now!

Glossary.md Outdated Show resolved Hide resolved
DesignRules.md Show resolved Hide resolved
DesignRules.md Show resolved Hide resolved
DesignRules.md Outdated Show resolved Hide resolved
@mrtn78 mrtn78 merged commit 2181501 into develop Jul 20, 2023
@mrtn78 mrtn78 deleted the AddGEORule branch July 20, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strijm strijm strijm approved these changes

@lvdbrink lvdbrink lvdbrink approved these changes

Assignees
No one assigned
Labels
Overleg: TO API Te agenderen voor het Technisch Overleg ADR - API Design Rules Scope: Groot Grote wijziging met grote impact Status: Ter goedkeuring Het voorstel is uitgewerkt en wordt ter goedkeuring aangeboden. Type: Wijziging Inhoudelijke wijziging op een standaard
Projects
None yet
Milestone
release 2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@mrtn78 @lvdbrink @strijm @sanderke