Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height is ignored (doesn't work well for Shorts) #336

Closed
dominictobias opened this issue May 23, 2024 · 1 comment
Closed

Height is ignored (doesn't work well for Shorts) #336

dominictobias opened this issue May 23, 2024 · 1 comment

Comments

@dominictobias
Copy link

dominictobias commented May 23, 2024

Describe the bug
Setting the height seems to have no effect - the video is still landscape.

To Reproduce

<YoutubePlayer
  webViewStyle={{ borderWidth: 1, borderColor: 'red' }}
  height={480}
/>

Expected behavior
Video should be portrait shaped

Screenshots
Instead the webview has a tall height, but the video is still landscape:

Screenshot 2024-05-23 at 6 09 19 PM

Smartphone (please complete the following information):

  • Device: iPhone15 Pro
  • OS + version: ios 17
  • react-native-youtube-iframe 2.3.0
  • react-native-webview 13.6.4
  • Expo verison 50

Additional context
It would be preferable for shorts to go straight to fullscreen mode as this fits portrait

@LonelyCpp
Copy link
Owner

if you want the player to expand into a custom height and ignore aspect-ratio, you can try this - #13 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants