-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iFrame padding/margin cannot be removed? #13
Comments
Hey! Can I have a screenshot of how it looks on your device? |
hmm, weird. I put in some CSS for the player to always maintain aspect ratio, which is causing the problem. I'll fix it with a patch update. Thanks for raising the issue. I'll let you know when I'm done |
Hey, can you try adding this -
If you make sure the container expands to full width, the video player also will match the parent. (but it wont preserve aspect ratio) |
The issue is with the body, it has a margin and padding by default. |
Hi @bulby97 If you see the html here, the container has the following style -
This causes the player to fit appropriately in the view port, maintaining aspect ratio at all times. It makes sure the player doesn't overflow if the containing view is less than 400px in width. Detailed explanation here. |
@LonelyCpp But @bulby97 is right, the HTML body usually has a margin of 8px, maybe it would help to just add |
TIL |
Hey @bulby97, I've left out the placeholder in favour or the I recommend you to handle the placeholder outside the library (maybe an opaque view over the player till |
Removed HTML body default margin (#13)
Fixed! |
Actually you're right mate ! Thanks. |
Thanks, you saved my time |
this works but causes a bug where returning from fullscreen ruins the video |
Thanks to @bastianspirek for their comment, I am wrapping my
The |
I am trying to display the player with a width of 100%, however I am not able to remove the margin/padding completely. I tried using width={"100%"} and webViewStyle={{ marginHorizontal: 0, paddingHorizontal: 0}} however there will always be a white space around it. Is there anything else that I can change? I am not sure where this space is coming from.
The text was updated successfully, but these errors were encountered: