Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Busy state overwrite on join request #81

Closed
ettmyfox opened this issue May 17, 2016 · 1 comment
Closed

Busy state overwrite on join request #81

ettmyfox opened this issue May 17, 2016 · 1 comment

Comments

@ettmyfox
Copy link

Hi,

in LoRaMacMlmeRequest function, in case MLME_JOIN, if LoRaMacState is equal to MAC_TX_DELAYED then status is set to LORAMAC_STATUS_BUSY. But status is overwrite some lines below.
I think line : "status = LORAMAC_STATUS_BUSY;" should be " return LORAMAC_STATUS_BUSY;"

Regards,
@djaeckle
Copy link

Hi ettmyfox,

thanks for the report. This is correct. We will apply a fix on the develop branch.

djaeckle pushed a commit that referenced this issue May 18, 2016
Issue(#81): Bug fix in function LoRaMacMlmeRequest case MLME_JOIN. Fu…
a28b744 
…nction will return LORAMAC_STATUS_BUSY in case the MAC is in status MAC_TX_DELAYED.
@mluis1 mluis1 closed this as completed Jun 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mluis1 @ettmyfox @djaeckle