Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid duplicate uplink sequence numbers when receiving bad MIC or add… #22

Closed
wants to merge 3 commits into from

Commits on Nov 2, 2015

  1. Avoid duplicate uplink sequence numbers when receiving bad MIC or add…

    …ress in confirmed transmits.
    
    If during a confirmed message transmission we receive a downlink frame with either
    an address not matching ours, or an incorrect MIC, control is returned to the user
    application with an error status, and the upLinkCounter is not incremented. Thus,
    the next uplink frame is sent with the same sequence number, and likely discarded
    by the receiving server.
    
    The fix involves discarding the invalid downlink and continuing the retransmission
    of the uplink frame until either a downlink response/ack is received, or the retry
    count is reached.
    Marc Bongartz committed Nov 2, 2015
    Configuration menu
    Copy the full SHA
    50e057a View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2015

  1. Better fix coming -- Revert "Avoid duplicate uplink sequence numbers …

    …when receiving bad MIC or address in confirmed transmits."
    
    This reverts commit 50e057a.
    Marc Bongartz committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    a61a0ea View commit details
    Browse the repository at this point in the history
  2. Fix uplink counter for MIC or address errors during confirmed uplinks.

    The uplink counter would not be incremented if, during a confirmed uplink
    transmission, the mac receives a frame with an invalid address or mic error.
    
    In addition, no further retransmissions would occur after such a downlink.
    
    This change should address the above two issues.
    Marc Bongartz committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    b1428a8 View commit details
    Browse the repository at this point in the history