Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve sign of negative SNR for DevStatusAns #524

Closed
wants to merge 1 commit into from
Closed

Preserve sign of negative SNR for DevStatusAns #524

wants to merge 1 commit into from

Conversation

reissjason
Copy link
Contributor

Device Status Answer removed the signed bit.

@reissjason
Preserve sign of negative SNR for DevStatusAns
01e5324 
Device Status Answer removed the signed bit.
@mluis1
Copy link
Contributor

mluis1 commented Nov 14, 2018

Thanks for the proposition.
Will be fixed with corrections provided to fix pull-requests #584 and #585

mluis1 added a commit that referenced this pull request Nov 15, 2018
@mluis1
Updated radio drivers to report the received SNR in dB and rounded to…
7c3953e 
… the nearest integer instead of register raw value.

All SNR variables are now declared signed 8 bits integer.

Issue(#475), Pull-Request(#584, #585, #524)
@mluis1 mluis1 closed this Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reissjason @mluis1