Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore join accept message if already joined #6

Closed
wants to merge 1 commit into from

Conversation

reissjason
Copy link
Contributor

There could be an instance when a join accept message is received inadvertently, then a new address would be assigned and new keys computed.

There could be an instance when a join accept message is received inadvertently, then a new address would be assigned and new keys computed.
@mluis1
Copy link
Contributor

mluis1 commented Jun 26, 2015

The behavior that you are observing shouldn't happen as each node should have a different AppKey (increases the network security) which implies that the MIC computation should fail.
The proposed correction is not enough because by just applying your patch the nodes will no more be able to rejoin a network (unless by resetting the node). The LoRaWAN specification allows network roaming which implies that the node must redo a Join procedure in such situations.

On the next version I'll try to integrate a fix for this situation.

@mluis1 mluis1 closed this Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants