Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.c to handle test mode tx dutycycle for dutycle enabled regions #630

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

ConnyBusy
Copy link
Contributor

@ConnyBusy ConnyBusy commented Dec 28, 2018

While trying to run certification tests. I realized that there were missing defined( Region_XXXXX ) for other dutycycle enabled regions like CN779, RU864, etc for the 5s TX duty cycle. This pull request updates/resolves it.

While truing to run certification tests. I realized that there were missing defined( Region_XXXXX ) for other dutycycle enabled regions like CN779, RU864, etc for the 5s TX duty cycle. This pull request updates/resolves it.
Copy link
Contributor

@mluis1 mluis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposition.
But, you have only applied your changes to one example.
Could you please update all others as well?

@ConnyBusy
Copy link
Contributor Author

Done!

@ConnyBusy ConnyBusy changed the title Update main.c Update main.c to handle test mode tx dutycycle for dutycle enabled regions Jan 14, 2019
@mluis1 mluis1 merged commit 4177ef1 into Lora-net:develop Jan 14, 2019
@mluis1
Copy link
Contributor

mluis1 commented Jan 14, 2019

Thanks for the proposition.

As the changes on the main.c files concerns all the same topic you could have made only one commit for all files.

mluis1 added a commit that referenced this pull request Jan 14, 2019
mvds00 pushed a commit to mvds00/LoRaMac-node that referenced this pull request Jan 27, 2019
@mluis1 mluis1 added this to the Release Version 4.4.2 milestone Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants