LoRaMacCommands.c: Most compilers need (void) instead of () in the de… #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UweBonnes
force-pushed
the
develop
branch
2 times, most recently
from
95b0ab2
to
1f30686
Compare
mluis1
requested changes
Apr 17, 2019
There was a problem hiding this comment.
Thanks for the proposition.
While reviewing the LoRaMacCommands.c we noticed that in plus of your catch the file didn't really followed the coding conventions in place.
Could you please apply the attached patch?
Once done please update the pull-request and we will merge it.
Make isSlotFree() and mallocNewMacCommandSlot() static. Follow coding convention, provided by mluis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…finition.