Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upsampling option to PositionGroup #1008

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Add upsampling option to PositionGroup #1008

merged 9 commits into from
Jul 1, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Jun 24, 2024

Description

Resolves #1006
Allows for upsampling position data within PositionGroup. This enables decoding with data from any position pipeline

  • adds secondary key upsample_rate to PositionGroup
  • adds method PositionGroup._upsample()
  • Moves shared functionality of ClusterlessDecodingV1.fetch_position_info() and SortedSpikesGroupV1.fetch_position_info() into new method PositionGroup.fetch_position_info

Checklist:

  • no This PR should be accompanied by a release: (yes/no/unsure)
  • n/a If release, I have updated the CITATION.cff
  • yes This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • n/a If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

@edeno edeno self-requested a review June 25, 2024 18:20
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@samuelbray32 samuelbray32 marked this pull request as ready for review June 27, 2024 18:09
@samuelbray32 samuelbray32 requested a review from edeno June 27, 2024 18:09
@edeno edeno merged commit 1445b67 into master Jul 1, 2024
7 checks passed
@edeno edeno deleted the dlc_upsample branch July 1, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upsample DLC Position
2 participants