Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove problem key in DLCPosV1 fetch_nwb attrs #1011

Merged
merged 2 commits into from
Jun 25, 2024
Merged

remove problem key in DLCPosV1 fetch_nwb attrs #1011

merged 2 commits into from
Jun 25, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Jun 25, 2024 •
edited
Loading

Description

Resolves #1010

  • add class specific method for DLCPosV1.fetch_nwb()
  • explicitly avoid the pose_eval_result from going into attrs of SpyglassMixin.fetch_nwb()
  • this avoids the SQL error

Checklist:

  • no This PR should be accompanied by a release: (yes/no/unsure)
  • n/a If release, I have updated the CITATION.cff
  • no This PR makes edits to table definitions: (yes/no)
  • n/a If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • n/a I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 June 25, 2024 17:58
@edeno edeno merged commit b5ba05a into master Jun 25, 2024
7 checks passed
@edeno edeno deleted the dlc_fetch_bug branch June 25, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

@CBroz1 CBroz1 Awaiting requested review from CBroz1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL error in DLCPosV1.fetch_nwb()
2 participants
@samuelbray32 @edeno