Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1016 - Allow ModuleNotFoundError #1023

Merged
merged 2 commits into from
Jul 9, 2024
Merged

#1016 - Allow ModuleNotFoundError #1023

merged 2 commits into from
Jul 9, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Jul 9, 2024 •
edited
Loading

Description

Allow ModuleNotFoundError in all cases of failed imports

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • No. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review July 9, 2024 21:47
@edeno edeno merged commit 3ccda24 into LorenFrankLab:master Jul 9, 2024
7 checks passed
@edeno edeno mentioned this pull request Jul 9, 2024
Closed
@CBroz1 CBroz1 deleted the 1016 branch August 6, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CBroz1 @edeno