Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable AnalysisFile logging #1024

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Disable AnalysisFile logging #1024

merged 3 commits into from
Jul 10, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Jul 9, 2024

Description

Preserves infrastructure for logging pending full analysis of this data.

Available to sit on or merge as we see fit.

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a. If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@edeno
Copy link
Collaborator

edeno commented Jul 9, 2024

Hm, I was imagining pulling out all the infrastructure to prevent it from causing lag to processing.

@CBroz1
Copy link
Member Author

CBroz1 commented Jul 10, 2024

I'd imagined pulling out the infrastructure after we're done the data analysis - in case it's inconclusive for whatever reason. There's always pulling from the history, but I think I would prefer deleting unused that the merge conflicts of pulling it back in

@edeno edeno merged commit d0ffae4 into LorenFrankLab:master Jul 10, 2024
7 checks passed
@CBroz1 CBroz1 deleted the nolog branch July 12, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants