Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix interpolation of nans in decoding position #1033

Merged
merged 12 commits into from
Aug 6, 2024
Merged

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Jul 12, 2024

Description

Resolves #1032

  • When upsampling data in PositionGroup preserve nan position values from source
  • In ClusterlessDecodingV1 and SortedSpikesDecodingV1
    • Set is_training = False for nan valued position timepoints

Checklist:

  • no This PR should be accompanied by a release: (yes/no/unsure)
  • n/a If release, I have updated the CITATION.cff
  • no This PR makes edits to table definitions: (yes/no)
  • n/a If table edits, I have included an alter snippet for release notes.
  • n/a If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • n/a I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review July 15, 2024 18:21
@samuelbray32 samuelbray32 marked this pull request as draft July 15, 2024 19:19
@samuelbray32 samuelbray32 marked this pull request as ready for review August 2, 2024 17:03
src/spyglass/decoding/v1/core.py Outdated Show resolved Hide resolved
src/spyglass/decoding/v1/clusterless.py Show resolved Hide resolved
src/spyglass/decoding/v1/core.py Outdated Show resolved Hide resolved
src/spyglass/decoding/v1/core.py Outdated Show resolved Hide resolved
@edeno edeno merged commit 9cd32e7 into master Aug 6, 2024
3 checks passed
@edeno edeno deleted the nan_interpolate branch August 6, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interpolation of nan values in PositionGroup
2 participants