Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quick fix for issue 1045 #1046

Merged
merged 6 commits into from
Aug 2, 2024
Merged

quick fix for issue 1045 #1046

merged 6 commits into from
Aug 2, 2024

Conversation

MichaelCoulter
Copy link
Collaborator

@MichaelCoulter MichaelCoulter commented Jul 26, 2024

the issue about lists vs array for lfp artifact removed intervals

Description

Please include a summary of the changes and the related issue. Please also
include relevant motivation and context. Please list issues fixed or closed by
This PR.

  • Fixes #000: How this PR fixes the issue
    • path/file.py: Description of the change
    • path/file.py: Description of the change
  • Fixes #000: How this PR fixes the issue
    • path/file.py: Description of the change
    • path/file.py: Description of the change

Checklist:

  • [no] This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • [no] This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

the issue about lists vs array for lfp artifact removed intervals
@CBroz1
Copy link
Member

CBroz1 commented Jul 26, 2024

Hi @MichaelCoulter - Thanks for putting the PR together. I'm inclined to wait on this until @edeno is back from vacation on Monday to review. Please let me know if you need it live sooner

The failing test can be fixed by running black (>= 24.0) on the file you edited. Please edit the Changelog and tick off the boxes in the PR template accordingly. Most items (e.g., tests, notebooks) can be marked with 'n/a'

@MichaelCoulter
Copy link
Collaborator Author

i fixed the formatting and updated the changelog.

@edeno edeno self-requested a review August 1, 2024 23:26
@edeno edeno merged commit 5145ff6 into master Aug 2, 2024
3 checks passed
@edeno edeno deleted the MichaelCoulter-patch-1 branch August 2, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants