-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce duplication 2 #1053
Reduce duplication 2 #1053
Conversation
@@ -542,24 +503,12 @@ def get_firing_rate( | |||
np.ndarray | |||
time-dependent firing rate with shape (len(time), n_units) | |||
""" | |||
spike_indicator = cls.get_spike_indicator(key, time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave this as it is useful to get the array.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure - I'll remove the comment. Do you feel the same about the others listed in the description?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I would leave them in for now.
Description
This PR builds on #1050 after confirmation from @khl02007 that the variable name change of
amplitude_thresh
->amplitude_thresh_uV
was not due to underlying packages. This moves the following funcs to a utils file..._check_artifact_thresholds
_compute_artifact_chunk
_init_artifact_worker
This also reduces the line count for both clusterless and spiked versions of
get_decoding_data_for_epoch
indecoding.v0
I was also able to move the following to utils...
git_interval_range
- fromdecoding.v1
get_firing_rate
save for the piece that depends on another class method (a good candidate for round 3)Do the following need to be public functions? If not, I think they can be removed, as they are not called within the codebase
spikesorting_merge.get_spike_indicator
spikesorting.vX.recording._get_recording_timestamps
decoding.v1.X.get_firing_rate
linearization.vX.TrackGraph.get_networkx_track_graph
: this is a relatively simple func that, if it doesn't need to be public, can probably be merged into calling functionsChecklist:
CITATION.cff
alter
snippet for release notes.CHANGELOG.md
with PR number and description.