Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spikesort artifact fixes #1069

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Spikesort artifact fixes #1069

merged 3 commits into from
Aug 15, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Aug 15, 2024 •
edited
Loading

Description

Checklist:

  • No This PR should be accompanied by a release: (yes/no/unsure)
  • NA If release, I have updated the CITATION.cff
  • No This PR makes edits to table definitions: (yes/no)
  • NA If table edits, I have included an alter snippet for release notes.
  • NA If this PR makes changes to position, I ran the relevant tests locally.
  • I have updated the CHANGELOG.md with PR number and description.
  • NA I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 marked this pull request as ready for review August 15, 2024 15:45
@samuelbray32
Copy link
Collaborator Author

Note: made the change in a way such that don't need to alter parameter names in existing parameter table entries

CBroz1
CBroz1 approved these changes Aug 15, 2024
View reviewed changes
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this - apologies for all the bugs leftover from my duplication PRs

src/spyglass/spikesorting/v0/spikesorting_artifact.py
@@ -73,6 +73,8 @@ class ArtifactDetection(SpyglassMixin, dj.Computed):
artifact_removed_interval_list_name: varchar(200) # name of the array of no-artifact valid time intervals
"""

_parallel_make = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this change be mentioned in the changelog too?

@CBroz1 CBroz1 merged commit fa968bb into master Aug 15, 2024
3 checks passed
@CBroz1 CBroz1 deleted the 1068_fix branch August 15, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent parameter name in artifact util functions
2 participants
@samuelbray32 @CBroz1