Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dj dependency to 0.14.2 #1081

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Bump dj dependency to 0.14.2 #1081

merged 8 commits into from
Sep 5, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented Aug 27, 2024

Description

Directly related to bump

Remove delete_downstream_parts in favor of new DJ force_masters

  • docs/src/Features/Mixin: remove mention of master/parts in docs on delete
  • pyproject.toml: bump datajoint pin
  • dj_mixin.py
    • remove part_masters and delete_downstream_parts
    • add check of dj version and, if updated, set force_masters flag

Misc cleanup

  • Edit CITATION.cff to be current with release
  • Add docs discussion of no-transaction populate from Allow disable transaction for select populates #1067
  • Add docs discussion of find_insert_fail tool
  • Edit is_merge_table to permit space variance in table definition, fix related test
  • Remove unnecessary teardown deletes
  • Add test of load_shared_schemas tool
Test coverage
---------- coverage: platform linux, python 3.9.19-final-0 -----------
Name                                                       Stmts   Miss  Cover   Missing
----------------------------------------------------------------------------------------
src/spyglass/common/common_behav.py                          276    113    59%   47-51, 84, 198, 226, 233-245, 312-316, 320-349, 352, 378, 384-450, 461-467, 497, 514, 521-589, 596, 625, 636-639, 642-643, 649, 667-678, 690
src/spyglass/common/common_dandi.py                          101    101     0%   1-279
src/spyglass/common/common_device.py                         203     96    53%   53-91, 124, 160-161, 205-206, 230-241, 273-309, 378-431, 456-473, 485-516, 549-550, 561, 615-618, 642, 675-679, 718-739
src/spyglass/common/common_dio.py                             52     15    71%   33-57, 129
src/spyglass/common/common_ephys.py                          307    236    23%   51-75, 101-184, 206-248, 273-335, 370-383, 409-425, 443-534, 538-547, 550-551, 616-702, 717-916, 919-920
src/spyglass/common/common_filter.py                         188    104    45%   23-24, 92-96, 99-102, 138-139, 215-220, 270-419, 451-520
src/spyglass/common/common_interval.py                       195     12    94%   51-73, 160-163, 532, 542
src/spyglass/common/common_lab.py                            111     25    77%   62, 69-70, 154-155, 266-281, 307-319
src/spyglass/common/common_nwbfile.py                        246    123    50%   68-77, 214, 228, 245-246, 289-309, 321-329, 353-356, 363, 370, 400-412, 449-525, 552-619, 636-655, 676-677, 691, 695-700, 704, 708-713, 722, 726-730, 763, 783-797
src/spyglass/common/common_position.py                       256    139    46%   28-30, 104-119, 131-204, 261-304, 350-351, 358-359, 375-448, 495, 519-595, 612-738
src/spyglass/common/common_region.py                          14      6    57%   48-57
src/spyglass/common/common_sensors.py                         24     10    58%   28-47
src/spyglass/common/common_session.py                        106     56    47%   57-129, 133-151, 157-180, 264-270
src/spyglass/common/common_subject.py                         21     12    43%   38-66
src/spyglass/common/common_task.py                            79     52    34%   34-40, 53-63, 83, 105-179, 183-190, 214
src/spyglass/common/common_usage.py                          137     35    74%   72-74, 104, 125-126, 184, 193, 201, 236, 247-251, 259-263, 280, 305-309, 313-324
src/spyglass/common/errors.py                                  2      0   100%
src/spyglass/common/populate_all_common.py                    49     36    27%   40-46, 69-92, 118-172
src/spyglass/common/prepopulate/prepopulate.py                44     31    30%   19, 24-74, 86-95
src/spyglass/common/signal_processing.py                      16     16     0%   1-57
src/spyglass/lfp/analysis/v1/lfp_band.py                     136     64    53%   107, 177-371, 434, 462
src/spyglass/lfp/lfp_electrode.py                             24      0   100%
src/spyglass/lfp/lfp_imported.py                              12      0   100%
src/spyglass/lfp/lfp_merge.py                                 22      0   100%
src/spyglass/lfp/v1/lfp.py                                    66     43    35%   62-197
src/spyglass/lfp/v1/lfp_artifact.py                           56     25    55%   130-201
src/spyglass/lfp/v1/lfp_artifact_MAD_detection.py             37     29    22%   42-63, 81, 107, 129-137, 157-176
src/spyglass/lfp/v1/lfp_artifact_difference_detection.py      79     69    13%   72-224, 253-280
src/spyglass/linearization/merge.py                           14      0   100%
src/spyglass/linearization/utils.py                            0      0   100%
src/spyglass/linearization/v0/main.py                         48     24    50%   60-62, 69-72, 86-90, 124-189, 192
src/spyglass/linearization/v1/main.py                         54     28    48%   54-56, 63-66, 80-84, 119-186, 189
src/spyglass/position/position_merge.py                       21      0   100%
src/spyglass/position/v1/dlc_reader.py                       112     86    23%   24-112, 116-119, 123-127, 131-133, 137-139, 143-144, 148, 151-164, 182-193, 213-224, 255-269
src/spyglass/position/v1/dlc_utils.py                        371    161    57%   58, 61, 69, 72, 97-100, 104, 149-163, 186, 211-224, 229-236, 248-262, 277-295, 314, 333, 414, 423, 429, 464, 477-508, 512-539, 558-573, 580-581, 586-632, 636-661, 667-679, 729, 802, 813
src/spyglass/position/v1/dlc_utils_makevid.py                246    213    13%   51-110, 113-118, 121-131, 134-150, 155-161, 164-168, 173-176, 179, 192-198, 219-221, 231-293, 296-339, 342-476, 479-486, 494-501, 504-553, 562
src/spyglass/position/v1/position_dlc_centroid.py            109     59    46%   46-62, 70-71, 136-139, 142, 154, 158-285
src/spyglass/position/v1/position_dlc_cohort.py               47     24    49%   58-72, 94-97, 101-130
src/spyglass/position/v1/position_dlc_model.py               123     73    41%   34-38, 85-98, 119-125, 133-134, 175-264, 285-329, 346-348
src/spyglass/position/v1/position_dlc_orient.py               75     35    53%   53-59, 68-69, 100-111, 115-183
src/spyglass/position/v1/position_dlc_pose_estimation.py     139     61    56%   75, 82, 129, 210-213, 217-349, 408-411, 435-447
src/spyglass/position/v1/position_dlc_position.py            180     99    45%   56, 63-77, 84-91, 99-100, 109-110, 164-168, 172-271, 344-405, 438-461, 465
src/spyglass/position/v1/position_dlc_project.py             214    134    37%   90-94, 129-202, 252-299, 303-329, 342-360, 404-405, 436-443, 450-453, 477-502, 522-549, 554-561
src/spyglass/position/v1/position_dlc_selection.py           125     70    44%   60-150, 196-262, 292-293, 321-424
src/spyglass/position/v1/position_dlc_training.py             89     45    49%   49, 63, 115-117, 121-224
src/spyglass/position/v1/position_trodes_position.py         104     40    62%   54, 63-64, 160-206, 210, 215, 249-319
src/spyglass/utils/database_settings.py                       99     15    85%   147, 162, 173-175, 179-183, 195, 211-214, 222, 225
src/spyglass/utils/dj_graph.py                               484     37    92%   51-52, 121, 259, 302, 371, 403, 469, 478, 518-527, 602-605, 624, 641-643, 658, 711, 924, 943, 949-950, 985, 1011, 1013, 1103-1105, 1118, 1128, 1130, 1149, 1173
src/spyglass/utils/dj_helper_fn.py                           188     91    52%   78, 101, 167-177, 182-191, 196-199, 292, 301-302, 313, 340-341, 367-429, 445-452, 472-488, 504-513, 528-529, 542-556
src/spyglass/utils/dj_merge_tables.py                        279     76    73%   35, 37, 43-47, 74-75, 91, 153, 179, 235, 241, 323-325, 329, 345, 351-352, 361, 413, 419, 457-463, 484-503, 533, 548, 550, 609, 615, 626, 673, 681, 702-708, 712, 733, 747, 783-784, 794, 804-810, 814-824, 831-834, 851-862
src/spyglass/utils/dj_mixin.py                               368     80    78%   87, 101, 238-249, 391-431, 452-453, 461, 513, 545-559, 581, 589, 598, 603-605, 614-636, 650-656, 675-678, 761, 768, 911, 937-938, 958-1026, 1037-1038
src/spyglass/utils/logging.py                                 17      2    88%   26-27
src/spyglass/utils/nwb_helper_fn.py                          168     44    74%   52-81, 100, 119, 133-138, 173-192, 216, 240-241, 285, 303, 413, 526, 543, 551-569
src/spyglass/utils/position.py                                13      9    31%   20-30
src/spyglass/utils/spikesorting.py                             9      6    33%   11-18
src/spyglass/utils/sql_helper_fn.py                           84     17    80%   45, 58-62, 91, 150, 184-185, 195-205
----------------------------------------------------------------------------------------
TOTAL                                                       6639   2977    55%

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a. If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a. If table edits, I have included an alter snippet for release notes.
  • N/a, but yes. If this PR makes changes to position, I ran the relevant tests locally.
  • Yes. I have updated the CHANGELOG.md with PR number and description.
  • Yes. I have added/edited docs/notebooks to reflect the changes

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 marked this pull request as ready for review September 3, 2024 21:38
@CBroz1 CBroz1 requested a review from edeno September 3, 2024 21:38
@CBroz1 CBroz1 requested a review from edeno September 5, 2024 18:55
@edeno edeno merged commit 5444097 into LorenFrankLab:master Sep 5, 2024
7 checks passed
@CBroz1 CBroz1 deleted the bdj branch September 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants