Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction on populate_all_common #957

Merged
merged 4 commits into from
May 10, 2024
Merged

Transaction on populate_all_common #957

merged 4 commits into from
May 10, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented May 7, 2024

Description

Fixes #612 by giving a user an arg to determine if the error is raised, rolling back the transaction.

Minor fixes:

  • add .py for mua notebook
  • change for loop insert1 to for loop append followed by single insert

Checklist:

  • NO. This PR should be accompanied by a release: (yes/no/unsure)
  • N/A. If release, I have updated the CITATION.cff
  • NO. This PR makes edits to table definitions: (yes/no)
  • N/A. If table edits, I have included an alter snippet for release notes.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

To do

Decide how to handle child tables. Current draft compromises in favor of two transactions.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CBroz1 CBroz1 marked this pull request as ready for review May 8, 2024 17:39
@edeno edeno merged commit 042fd1c into LorenFrankLab:master May 10, 2024
3 checks passed
@CBroz1 CBroz1 deleted the ppa branch May 10, 2024 21:04
@CBroz1 CBroz1 mentioned this pull request May 13, 2024
6 tasks
edeno pushed a commit that referenced this pull request May 13, 2024
* Address failing tests

* Revert to bare make for no transaction

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial session insert fail state
2 participants