Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QuickFix: Bug in curation v0 make #960

Merged
merged 1 commit into from
May 8, 2024
Merged

QuickFix: Bug in curation v0 make #960

merged 1 commit into from
May 8, 2024

Conversation

samuelbray32
Copy link
Collaborator

Description

Fixes #959
-Don't alter the make key with the analysis file name until after fetching waveform data

Checklist:

  • This PR should be accompanied by a release: no
  • N/A If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: no
  • N/A If table edits, I have included an alter snippet for release notes.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/A I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested review from edeno and CBroz1 May 8, 2024 17:31
@samuelbray32 samuelbray32 marked this pull request as ready for review May 8, 2024 17:32
@edeno edeno merged commit faf8a80 into master May 8, 2024
3 checks passed
@edeno edeno deleted the curation_analysis_key_bug branch May 8, 2024 17:32
@samuelbray32 samuelbray32 mentioned this pull request May 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

@CBroz1 CBroz1 Awaiting requested review from CBroz1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in Spikesorting v0 curation
2 participants
@samuelbray32 @edeno