Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests/doc build #967

Merged
merged 5 commits into from
May 10, 2024
Merged

Fix tests/doc build #967

merged 5 commits into from
May 10, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented May 10, 2024 •
edited
Loading

Description

  1. Pytests were failing because of an unnecessary teardown line
  2. Doc build was failing due to a bug(?) introduced in mkdocstrings-python==0.9.1. Discussion. I pinned the requirement for now
  3. Fixing the pin showed some cases of the build throwing warnings for existing docstrings. I fixec these cases.

Checklist:

  • No. This PR should be accompanied by a release: (yes/no/unsure)
  • N/a If release, I have updated the CITATION.cff
  • No. This PR makes edits to table definitions: (yes/no)
  • N/a If table edits, I have included an alter snippet for release notes.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/a. I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review May 10, 2024 16:11
@CBroz1 CBroz1 requested a review from edeno May 10, 2024 16:19
@edeno edeno merged commit a508b57 into LorenFrankLab:master May 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CBroz1 @edeno