Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup of dlc video #975

Merged
merged 4 commits into from
May 15, 2024
Merged

Cleanup of dlc video #975

merged 4 commits into from
May 15, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented May 15, 2024

Description

Fixes #974
DLCPosVideo

  • get epoch directly from key to avoid missing interval error
  • default to opencv for video writing

Other

Checklist:

  • This PR should be accompanied by a release: no
  • N/A If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: no
  • N/A If table edits, I have included an alter snippet for release notes.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

@edeno
Copy link
Collaborator

edeno commented May 15, 2024

Do you feel like there's a further issue here that there are no position intervals when DLC is used? I could imagine it messing up other aspects of spyglass.

@samuelbray32
Copy link
Collaborator Author

  • I don't think that any of the spyglass package is dependent on that existing ( or at least LinearizedPosV1 and SortedSpikesDecoding don't).
  • just making an interval wouldn't be enough to be able to restrict on it in the dlc tables (if that's the reason why desired). Would need to alter table(s) to add that as a secondary key

My current thought would be no, but I might be missing the general use case for it

@edeno edeno merged commit 8872043 into master May 15, 2024
7 checks passed
@edeno edeno deleted the dlc_video branch May 15, 2024 19:06
CBroz1 added a commit to CBroz1/spyglass that referenced this pull request Oct 22, 2024
edeno pushed a commit that referenced this pull request Oct 29, 2024
* Use provided epoch

* Save video to temp dir

* Remove open-cv support

* WIP: Multithread, RAM hungry

* Limit number of workers

* Save file images in batches

* Reduce RAM cost, remove cv2 dep

* Update changelog

* Get debug arg from params

* Revert merge error #870, #975

* Adjust for final frame. Resume from existing

* Resume from fail

* except IndexError for final frame

* Delay delete temp files until complete

* Explicit error messages

* Return video object for debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLC Centroid populate error with spatial_series
2 participants