Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace old join call with cascade #982

Merged
merged 2 commits into from
May 20, 2024
Merged

Replace old join call with cascade #982

merged 2 commits into from
May 20, 2024

Conversation

CBroz1
Copy link
Member

@CBroz1 CBroz1 commented May 20, 2024 •
edited
Loading

Description

#949 replaced TableChain.join with cascade to align with other dj_graph classes. This PR fixes a holdover instaces within cautious_delete

Checklist:

  • NO This PR should be accompanied by a release: (yes/no/unsure)
  • N/A If release, I have updated the CITATION.cff
  • NO This PR makes edits to table definitions: (yes/no)
  • N/A If table edits, I have included an alter snippet for release notes.
  • I have updated the CHANGELOG.md with PR number and description.
  • N/A I have added/edited docs/notebooks to reflect the changes

@CBroz1 CBroz1 marked this pull request as ready for review May 20, 2024 16:18
@edeno edeno linked an issue May 20, 2024 that may be closed by this pull request
'TableChain' object has no attribute 'join' #981
Closed
@edeno edeno merged commit 26e74a4 into LorenFrankLab:master May 20, 2024
6 checks passed
@CBroz1 CBroz1 deleted the 981 branch May 20, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'TableChain' object has no attribute 'join'
2 participants
@CBroz1 @edeno