Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check existence of optional fields during Electrode table population #985

Merged
merged 4 commits into from
May 21, 2024

Conversation

khl02007
Copy link
Collaborator

@khl02007 khl02007 commented May 21, 2024

Description

The only required fields for nwbfile.add_electrode are location and electrode group (https://pynwb.readthedocs.io/en/stable/pynwb.file.html#pynwb.file.NWBFile.add_electrode). Therefore some NWB files may not other fields such as filtering. Spyglass should check if these exist before trying to populate them; otherwise they should get the default value (e.g. NULL)

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • If release, I have updated the CITATION.cff
  • This PR makes edits to table definitions: (yes/no)
  • If table edits, I have included an alter snippet for release notes.
  • I have updated the CHANGELOG.md with PR number and description.
  • I have added/edited docs/notebooks to reflect the changes

@khl02007 khl02007 requested review from CBroz1 and edeno May 21, 2024 03:30
src/spyglass/common/common_ephys.py Outdated Show resolved Hide resolved
src/spyglass/common/common_ephys.py Show resolved Hide resolved
src/spyglass/common/common_ephys.py Outdated Show resolved Hide resolved
src/spyglass/common/common_ephys.py Outdated Show resolved Hide resolved
@edeno edeno requested a review from CBroz1 May 21, 2024 19:07
@edeno edeno merged commit ae4a7b8 into LorenFrankLab:master May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants