resolve and document fontbakery FAILs

Losangelosgenetics · Mar 26, 2019 · 6ee86a6 · 6ee86a6
1 parent 7919f1e
commit 6ee86a6
Show file tree

Hide file tree

Showing 11 changed files with 230 additions and 123 deletions.
diff --git a/FiraCode.glyphs b/FiraCode.glyphs
@@ -234,31 +234,31 @@ capHeight = 1374;
 customParameters = (
 {
 name = typoAscender;
-value = 1870;
+value = 1980;
 },
 {
 name = typoDescender;
-value = -530;
+value = -644;
 },
 {
 name = typoLineGap;
 value = 0;
 },
 {
 name = winAscent;
-value = 1870;
+value = 2164;
 },
 {
 name = winDescent;
-value = 530;
+value = 1000;
 },
 {
 name = hheaAscender;
-value = 1870;
+value = 1980;
 },
 {
 name = hheaDescender;
-value = -530;
+value = -644;
 },
 {
 name = hheaLineGap;
@@ -300,31 +300,31 @@ capHeight = 1386;
 customParameters = (
 {
 name = typoAscender;
-value = 1870;
+value = 1980;
 },
 {
 name = typoDescender;
-value = -530;
+value = -644;
 },
 {
 name = typoLineGap;
 value = 0;
 },
 {
 name = winAscent;
-value = 1870;
+value = 2164;
 },
 {
 name = winDescent;
-value = 530;
+value = 1000;
 },
 {
 name = hheaAscender;
-value = 1870;
+value = 1980;
 },
 {
 name = hheaDescender;
-value = -530;
+value = -644;
 },
 {
 name = hheaLineGap;
@@ -107244,6 +107244,10 @@ name = "Remove Features";
 value = (
 cpsp
 );
+},
+{
+name = weightClass;
+value = 300;
 }
 );
 interpolationWeight = 62;
@@ -107260,6 +107264,10 @@ name = "Remove Features";
 value = (
 cpsp
 );
+},
+{
+name = weightClass;
+value = 400;
 }
 );
 interpolationWeight = 84;
@@ -107270,11 +107278,10 @@ instanceInterpolations = {
 name = Regular;
 },
 {
-exports = 0;
 customParameters = (
 {
 name = weightClass;
-value = 900;
+value = 450;
 },
 {
 name = "Remove Features";
@@ -107289,6 +107296,7 @@ instanceInterpolations = {
 "B67F0F2D-EC95-4CB8-966E-23AE86958A69" = 0.64583;
 };
 name = Retina;
+weightClass = Normal;
 },
 {
 customParameters = (
@@ -107297,6 +107305,10 @@ name = "Remove Features";
 value = (
 cpsp
 );
+},
+{
+name = weightClass;
+value = 500;
 }
 );
 interpolationWeight = 112;
@@ -107334,6 +107346,10 @@ name = "Remove Features";
 value = (
 cpsp
 );
+},
+{
+name = weightClass;
+value = 700;
 }
 );
 interpolationWeight = 158;

diff --git a/distr/ttf/FiraCode-Bold.ttf b/distr/ttf/FiraCode-Bold.ttf
diff --git a/distr/ttf/FiraCode-Light.ttf b/distr/ttf/FiraCode-Light.ttf
diff --git a/distr/ttf/FiraCode-Medium.ttf b/distr/ttf/FiraCode-Medium.ttf
diff --git a/distr/ttf/FiraCode-Regular.ttf b/distr/ttf/FiraCode-Regular.ttf
diff --git a/distr/ttf/FiraCode-Retina.ttf b/distr/ttf/FiraCode-Retina.ttf
diff --git a/distr/variable_ttf/FiraCode-VF.ttf b/distr/variable_ttf/FiraCode-VF.ttf
diff --git a/distr/variable_ttf/FiraCode-VF.ttx b/distr/variable_ttf/FiraCode-VF.ttx
diff --git a/googlefonts-qa/checks/FiraCode-Light.checks.md b/googlefonts-qa/checks/FiraCode-Light.checks.md
@@ -267,11 +267,10 @@ But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica
 
 </details>
 <details>
-<summary>🔥 <b>FAIL:</b> Checking OS/2 usWinAscent & usWinDescent.</summary>
+<summary>🔥 <b>FAIL:</b> Variable font weight coordinates must be multiples of 100.</summary>
 
-* [com.google.fonts/check/family/win_ascent_and_descent](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/family/win_ascent_and_descent)
-* 🔥 **FAIL** OS/2.usWinAscent value should be equal or greater than 2100, but got 1870 instead [code: ascent]
-* 🔥 **FAIL** OS/2.usWinDescent value should be equal or greater than 1000, but got 530 instead [code: descent]
+* [com.google.fonts/check/varfont_weight_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_weight_instances)
+* 🔥 **FAIL** Found an variable font instance with 'wght'=450.0. This should instead be a multiple of 100.
 
 </details>
 <details>
@@ -444,9 +443,9 @@ But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica
 
 |  | FiraCode-Light.ttf |
 |:--- | ---:|
-| Dehinted Size | 238.0kb |
+| Dehinted Size | 238.1kb |
 | Hinted Size | 236.1kb |
-| Increase | -1996 bytes |
+| Increase | -1992 bytes |
 | Change   | -0.8 % |
 
 
@@ -494,7 +493,7 @@ The version string must ideally include a git commit hash and either a 'dev' or
 <summary>ℹ <b>INFO:</b> Font contains all required tables?</summary>
 
 * [com.google.fonts/check/required_tables](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/required_tables)
-* ℹ **INFO** This font contains the following optional tables [GPOS, gasp, DSIG, loca, GSUB, prep]
+* ℹ **INFO** This font contains the following optional tables [GSUB, loca, GPOS, DSIG, gasp, prep]
 * 🍞 **PASS** Font contains all required tables.
 
 </details>
@@ -808,6 +807,13 @@ The version string must ideally include a git commit hash and either a 'dev' or
 * [com.google.fonts/check/varfont/has_HVAR](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont/has_HVAR)
 * 🍞 **PASS** This variable font contains an HVAR table.
 
+</details>
+<details>
+<summary>🍞 <b>PASS:</b> Checking OS/2 usWinAscent & usWinDescent.</summary>
+
+* [com.google.fonts/check/family/win_ascent_and_descent](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/family/win_ascent_and_descent)
+* 🍞 **PASS** OS/2 usWinAscent & usWinDescent values look good!
+
 </details>
 <details>
 <summary>🍞 <b>PASS:</b> Checking OS/2 Metrics match hhea Metrics.</summary>
@@ -850,13 +856,6 @@ The version string must ideally include a git commit hash and either a 'dev' or
 * [com.google.fonts/check/varfont_has_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_has_instances)
 * 🍞 **PASS** OK
 
-</details>
-<details>
-<summary>🍞 <b>PASS:</b> Variable font weight coordinates must be multiples of 100.</summary>
-
-* [com.google.fonts/check/varfont_weight_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_weight_instances)
-* 🍞 **PASS** OK
-
 </details>
 <details>
 <summary>🍞 <b>PASS:</b> Checking with ftxvalidator.</summary>