fix(player): add isConnected check to disconnectedCallback #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good @billerr . will merge after testing it and add to next release. Thanks! |
|
Is there an ETA for the next release? This is causing issues with GSAP scrollTrigger as when the player or it’s parent has pinning it disappears. |
|
🎉 This pull request is included in v1.5.7, available on npm: @lottiefiles/lottie-player@1.5.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
isConnectedcheck (as per the documentation) to thedisconnectedCallback, to avoid clean-up in cases where the node was not removed, but moved (likeinsertBeforeand similar).This is a fix for issue #152