-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert, split up and reorganize tests #4
Comments
Just a side note: I hope that the test files are not too fragmented. With the data driven approach I proposed in #5, we can organize multiple (related) test cases in a single test file while still having the capability of running each test case separately (like temporarily adding a special |
Just a note to myself: special care must be taken when modifying existing test Lua code (better not touch at all unless extremely necessary), since even some minor changes may make the bug that it exercises no longer reproducible. I think the data driven approach can make the changes we perform to the existing test code minimal. |
That's alright.� It was a small enough change that it doesn't really matter, and it's got us moving in some direction. So, we now know the process we want to follow is to have a branch or fork and do pull requests, even though we individually have write permissions. Does this come with an approval process as well?� Like, at least one other maintainer needs to agree for the pull request to be accepted? -- William
|
Now that we're back to square zero. Is anyone going to check in anything of substance? Are we really going to wait until the whole test framework issue is resolved before we attempt to do anything? |
Split up the tests in to many small tests, and convert them into the format required by the testing framework where applicable. Reorganize them into the new directory structure.
The text was updated successfully, but these errors were encountered: