Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema link to .luarc.json. #2679

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

notpeter
Copy link
Contributor

Add json schema link to .luarc.json.

@sumneko sumneko merged commit eb93166 into LuaLS:master May 25, 2024
10 checks passed
@notpeter notpeter deleted the luarc_add_schema branch May 25, 2024 12:52
@VerscheldeAlynne
Copy link

VerscheldeAlynne commented Jun 11, 2024

Rather than opening an issue I will comment here.

How are you using the lua-language-server?

Freshly installed via VSCode

Which OS are you using?

Windows 10

What is the issue affecting?

Schema link in .luarc.json on generation of aformentioned file

Expected behavior

Schema link should look like this "$Schema"

image

Actual behavior

Instead the Schema link looks like this $Schema it generates without the "
image

Additional Notes

None

EDIT: made the expected behaviour and actual behaviour more clear using a comment

@notpeter
Copy link
Contributor Author

notpeter commented Jun 11, 2024

I don't understand the issue you are having. Shouldn't $schema be "$schema" in the second example? (missing ")

@VerscheldeAlynne
Copy link

@notpeter Yes, that is exactly the problem. It is indeed missing the " in the actual behaviour. I'll reiterate my post to make the problem more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants