Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flip binary operator check if failed (#2777) #2779

Merged
merged 3 commits into from
Aug 6, 2024
Merged

feat: flip binary operator check if failed (#2777) #2779

merged 3 commits into from
Aug 6, 2024

Commits on Aug 6, 2024

  1. feat: flip binary operator check if failed 

    if vm.runOperator fails try again with flipped arguments
this emulates how lua checks the binary metaevents in which
if there is no corresponding binary metaevent for the left
operand it checks the right operand instead. This also works
when both operands are tables.

This change affects:
- __add
- __sub
- __mul
- __div
- __idiv
- __mod
- __pow
- __concat
- __band
- __bor
- __bxor
- __shl
- __shr
    @SeanTheBuilder1 @sumneko
    SeanTheBuilder1 authored and sumneko committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    15c716d View commit details
    Browse the repository at this point in the history

  2. test: add test case for reversed binary operators

    @SeanTheBuilder1 @sumneko
    SeanTheBuilder1 authored and sumneko committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    6ebd54a View commit details
    Browse the repository at this point in the history

  3. docs: update changelog

    @SeanTheBuilder1 @sumneko
    SeanTheBuilder1 authored and sumneko committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8635fef View commit details
    Browse the repository at this point in the history